Leopard: Saving file in external editor doesn't cause upload

[danwood]

Using Leopard (9A527) and CyberDuck 2.8b1 (3212)/3212, and SubEthaEdit as an external editor, I notice that when editing a file and saving back, the file is not re-uploaded.

This is logged to the console:

9/10/07 12:58:29 PM Cyberduck[1178] handleModifiedFileEvent: Got ODB editor event for unknown file. 
9/10/07 12:58:30 PM Cyberduck[1178] handleClosedFileEvent: Got ODB editor event for unknown file. 

[andyfowler]

Just wanted to confirm that this is still occurring in final release. Tested using CyberDuck 2.8 r3257 and TextMate.

[jduffas]

I confirm : same problem, with any text editor.

[paodj]

I've the same problem with leopard final (golden master) with bbedit.

[GREENSKiN]

Confirmed under Leopard retail, with CyberDuck 2.8 (3257) and TextMate 1.5.7 (1436).

[GREENSKiN]

I inserted some debug code in the source... I think Leopard reports symlinks in a different way than Tiger did:

10/28/07 9:52:23 PM Cyberduck[13529] handleModifiedFileEvent: Got ODB editor event for unknown file (/private/var/folders/wO/wOFigXmSH9ykExpUW4b+qU+++TI/-Tmp-/var/www/test-3.php). 10/28/07 9:52:23 PM Cyberduck[13529] Dictionary contains... {

"/var/folders/wO/wOFigXmSH9ykExpUW4b+qU+++TI/-Tmp-/var/www/test-3.php" = {

ODBEditorFileName = "/var/folders/wO/wOFigXmSH9ykExpUW4b+qU+++TI/-Tmp-/var/www/test-3.php"; ODBEditorIsEditingString = 0; ODBEditorNonRetainedClient = <10291000>;

};

}

As you can see TextMate reports /private/var/... for the filename, whereas Cyberduck has stored /var/... in its dictionary object.

[GREENSKiN]

Patch!

\214c214
< 			[_filesBeingEdited setObject: dictionary forKey: [fileName stringByResolvingSymlinksInPath]];
---
> 			[_filesBeingEdited setObject: dictionary forKey: fileName];
233c233
< 	dictionary = [_filesBeingEdited objectForKey: [fileName stringByResolvingSymlinksInPath]];
---
> 	dictionary = [_filesBeingEdited objectForKey: fileName];
254c254
< 	dictionary = [_filesBeingEdited objectForKey: [fileName stringByResolvingSymlinksInPath]];
---
> 	dictionary = [_filesBeingEdited objectForKey: fileName];

[jduffas]

how do you patch the app ? would you put somewhere the app patched ?

jean

[andyfowler]

The patch from greenskin works great, though he forgot to mention the file to be patched:

cyberduck/source/ch/cyberduck/ui/cocoa/odb/ODBEditor.m

I've applied his patch to the latest svn version and compiled it as a temporary fix for anybody interested. Not sure if it's compatible with 10.4 but it works great in 10.5.

 http://www.createarevolution.com/downloads/cyberduck-r3260-10.5.zip

[dkocher]

Thanks for the patch! I will test under 10.3.9-10.5 and then apply. You will find the latest build at  http://update.cyberduck.ch/nightly/ then.

[dkocher]

I have added a cyberduck-dev mailing list to make it easier to discuss code. See #1202.

[dkocher]

In r3263.

[dkocher]

A new build is available at  http://update.cyberduck.ch/nightly/Cyberduck-3268.tar.gz

[chuckienorton]

I just downloaded the new build & still cannot even select an editor. (using leopard). Am I missing something?? Thanks, -Chuck

[GoClick]

It would be nice if that build were available by update in the client I didn't like having to search around in trac to find it. glas it's here though

[dkocher]

An official release is due soon but there are one or two other issues I want to have resolved first. Thanks for your patience.